[buddypress-trac] [BuddyPress] #4974: Add filters to bp_directory_groups_search_form() and bp_directory_members_search_form()

buddypress-trac noreply at wordpress.org
Tue Aug 6 08:44:42 UTC 2013


#4974: Add filters to  bp_directory_groups_search_form() and
bp_directory_members_search_form()
-------------------------+---------------------------
 Reporter:  megainfo     |       Owner:  boonebgorges
     Type:  enhancement  |      Status:  reopened
 Priority:  low          |   Milestone:  1.9
Component:  Theme        |     Version:
 Severity:  minor        |  Resolution:
 Keywords:  needs-patch  |
-------------------------+---------------------------

Comment (by hnla):

 > 1 - We've only changed it here because this is all the original patch
 did. It would be nice to extend the same treatment to all search form html
 generating functions. We just need a patch.

 The other two will need patching as it could prove awkward for developers
 wanting to re-factor all of them.

 >2 - I don't think it is used anywhere by BP, nor has it been for a number
 of years. We have to keep it in there for backward compatibility, as some
 themes/installations may be using it.

 Oh my favourite phrase 'backwards compatibility' -  I can't find theme use
 of the function checking back to 1.2 locally, although perhaps not
 strictly 'deprecated' can this not be pulled out of the file and added to
 one of those /bp-core/deprecated/ files, less clutter in current core
 files?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4974#comment:10>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list