[buddypress-trac] [BuddyPress] #4953: BuddyPress specific UI refresh

[buddypress-trac]

#4953: BuddyPress specific UI refresh
-------------------------+------------------
 Reporter:  karmatosed   |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  1.8
Component:  UX/UI        |     Version:
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+------------------

Comment (by hnla):

 >but we shouldn't, for example, change the names of CSS selectors. Any
 "modernization" that is truly substantial - say, reworking the whole thing
 to use HTML5 elements - should be done in a separate template pack.

 Yes the principle must always remain that existing and historic tokens are
 preserved and not changed, new ones can be added but old not removed and
 in the main the existing ones serve well enough and given how we unhooked
 the JS selectors from the tokens we have gained the ability to re-factor
 markup without upsetting the scripting behaviour.

 Substantial re-factoring will have to be reserved for new packs, we may be
 able to extract some of the markup from work done on the Status theme, as
 part of the scope Tammie and I tried to achieve there was  html5 elemenst
 & lightening of structure.

 >unless bp_nav_menu() outputs the exact same markup as the old function (I
 haven't checked)

 It's substantially different due to the now nested ul construct, however I
 tried to re-factor preserving the original outer elements wrapping
 bp_displayed_user_nav() to try and preserve any styles that might have
 relied on descendent styling, the new styles mimic the look pretty much of
 1.7 running under 2012 so in effect may just work copied over existing, be
 interesting to test. Original thought was users try it out by extracting
 from a zip the /members/ dir and templates dropped into /buddypress/ in
 their theme along with snippet enqueue function and stylesheet - it's
 usable one way or another, fiddly issues are bogging things down but going
 to zip it when done  so anyone can have a play.

 @ubernaut no worries just had a notion that you were probably over-
 thinking the complexity slightly and that although not simple processes
 also not too hard, and anyone can get stuck in, also think all comments
 are valid, we all use the stuff so and have valid opinions or thoughts.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4953#comment:5>
BuddyPress <http://buddypress.org/>
BuddyPress