[buddypress-trac] [BuddyPress] #4931: Add Friend - Cancel Friendship Request buttons behave inconsistently

buddypress-trac noreply at wordpress.org
Mon Apr 15 19:38:45 UTC 2013


#4931: Add Friend - Cancel Friendship Request buttons behave inconsistently
--------------------------+---------------------------
 Reporter:  dontdream     |       Owner:  boonebgorges
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  1.7.1
Component:  Theme         |     Version:  1.7
 Severity:  minor         |  Resolution:
 Keywords:                |
--------------------------+---------------------------
Changes (by boonebgorges):

 * owner:   => boonebgorges
 * status:  new => assigned
 * type:  enhancement => defect (bug)
 * severity:  normal => minor
 * milestone:  Awaiting Review => 1.7.1


Comment:

 Thanks. I've confirmed the issue. The problem is the pagination: because
 pages beyond #1 are loaded via AJAX, we need to use event delegation to
 bind the click event to the .friendship-button elements. See also #4458.

 The change is a result of r6635, which moved us from jQuery.live() to
 jQuery.on(). That migration was done incorrectly in this case (and, I'd
 wager, in the case of group directories as well).

 Because this is a regression from 1.6.x, I'm tentatively putting it in the
 1.7.1 milestone. I can write a patch later; it should be straightforward.
 If any devs object to making significant JS changes in a maintenance
 release, I suppose we can move it to 1.8.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4931#comment:3>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list