[buddypress-trac] [BuddyPress] #4546: Use locate_template() in bp_locate_template()

[buddypress-trac at lists.automattic.com]

#4546: Use locate_template() in bp_locate_template()
-------------------------------------------------+-------------------------
 Reporter:  r-a-y                                |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Core                                 |  Review
 Severity:  normal                               |     Version:  1.7
 Keywords:  has-patch 2nd-opinion reporter-      |  Resolution:
  feedback                                       |
-------------------------------------------------+-------------------------
Changes (by johnjamesjacoby):

 * keywords:  has-patch => has-patch 2nd-opinion reporter-feedback


Comment:

 I don't think the extra hook at the end is necessary, as hooks already
 exist to add additional templates in the stack. I'd rather those hooks
 were used than having everything get funneled into this one, at least
 until we see how theme compat works.

 It's possible I'm alone in this, but I like the simplicity of the original
 code here. Being able to see the stack of child, parent, theme-compat
 reads easier than using locate_template(). Also, if the functionality of
 locate_template() ever changes in !WordPress core, we're obligated to
 embrace that change forever, rather than on our own schedule.

 Adding 2nd-opinion tag to this, but for right now I'm a nay.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4546#comment:1>
BuddyPress <http://buddypress.org/>
BuddyPress