[buddypress-trac] [BuddyPress] #4305: Numeric Usernames and Private Messaging Bug

[buddypress-trac at lists.automattic.com]

#4305: Numeric Usernames and Private Messaging Bug
--------------------------+---------------------
 Reporter:  Robl987       |       Owner:
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  1.7
Component:  Messaging     |     Version:  1.5
 Severity:  normal        |  Resolution:  fixed
 Keywords:  commit        |
--------------------------+---------------------
Changes (by r-a-y):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 (In [6340]) Fix messages_new_message() so numeric usernames get parsed
 properly.

 Previously to this commit, numeric recipients were being checked
 against the user ID column with bp_core_get_core_userdata() only.

 This was considered okay since you cannot create a username with only
 numbers on the BP frontend registration page. However, you can create
 numeric usernames in the WP backend or if the site already uses
 numeric usernames via LDAP or some other login system.

 So, this commit also checks against user_login / user_nicename with
 bp_core_get_userid() / bp_core_get_userid_from_nicename() as well to
 be considerate to those use cases.

 Fixes #4305.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4305#comment:4>
BuddyPress <http://buddypress.org/>
BuddyPress