[buddypress-trac] [BuddyPress] #4429: User banned from public group can still reply to group activity items

[buddypress-trac at lists.automattic.com]

#4429: User banned from public group can still reply to group activity items
-------------------------------------+--------------------------
 Reporter:  DJPaul                   |       Owner:  rachelbaker
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  1.7
Component:  Activity                 |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+--------------------------

Comment (by DJPaul):

 Thanks for the patch, Rachel. Some initial feedback (I haven't tested the
 patch yet): we need to check that the Groups component is active before
 calling the function, and that the activity itself is related to a group.

 It might also be more elegant to hook into (for example)
 bp_activity_can_comment from inside the Groups component and do the logic
 there; it helps to keep components tidy and unentangled. I know there's
 lots of parts of core that don't do this, but it might be a nice thing to
 aim for going forward.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4429#comment:3>
BuddyPress <http://buddypress.org/>
BuddyPress