[buddypress-trac] [BuddyPress] #4624: Component subnav items should use displayed user domain, not loggedin user

[buddypress-trac]

#4624: Component subnav items should use displayed user domain, not loggedin user
--------------------------+--------------------
 Reporter:  boonebgorges  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  1.6.2
Component:  Core          |     Version:
 Severity:  major         |  Resolution:
 Keywords:  dev-feedback  |
--------------------------+--------------------

Comment (by boonebgorges):

 Thanks for the clarification, r-a-y. I forgot that the BuddyBar uses
 `$bp->bp_options_nav`. That's a real mess, IMO, and I wish we could just
 drop backward compatibility for it :-/

 Anyway, we can't simply do a test like you suggest. If I'm logged in as
 `boone`, and I visit `example.com/members/`, my BuddyBar links will point
 to *my* Profile, Groups, etc. This is expected, legacy behavior. However,
 when visiting a page like `example.com/members/r-a-y/`, those links would
 then point to *your* Profile, Groups, etc, which is not what we'd expect.

 My preference is to fix the components so that they work they way they
 ought to work (which is to say, using `bp_displayed_user_domain()`), and
 then to patch the BuddyBar for backward compatibility. If we're going to
 have a hack, I'd rather have it in a place where it's deprecated. The hack
 could be as simple as `str_replace( bp_displayed_user_domain(),
 bp_loggedin_user_domain(), $link )` - ugly, but straightforward.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4624#comment:2>
BuddyPress <http://buddypress.org/>
BuddyPress