[buddypress-trac] [BuddyPress] #3741: BuddyPress should have theme compatibility
buddypress-trac
noreply at wordpress.org
Mon Oct 22 10:56:04 UTC 2012
#3741: BuddyPress should have theme compatibility
-----------------------------+------------------------------
Reporter: johnjamesjacoby | Owner: johnjamesjacoby
Type: enhancement | Status: new
Priority: highest | Milestone: 1.7
Component: Theme | Version:
Severity: critical | Resolution:
Keywords: dev-feedback |
-----------------------------+------------------------------
Comment (by johnjamesjacoby):
Replying to [comment:44 DJPaul]:
> With the http://wordpress.org/extend/themes/easel theme, it access
$authordata->thing directly without checking if the property exist. As we
set post_author = 0 in the reset function, $authordata is never set and
this throws a php warning. Do we care about this situation, or want to
consider setting post_author = 1?
Good catch, but I don't think it matters. Accessing array keys or object
variables directly is fragile, and at worst triggers a debug notice for
those of us with WP_DEBUG on. Annoying, but not worth worrying about too
much.
Would probably make a better patch upstream to the theme author, to put an
empty() check in there to avoid the notice(s) as needed.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3741#comment:51>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list