[buddypress-trac] [BuddyPress] #4225: Messages - View/1/ reply to: results in undefined index /headers sent

[buddypress-trac at lists.automattic.com]

#4225: Messages - View/1/ reply to: results in undefined index /headers sent
--------------------------+-----------------------------
 Reporter:  hnla          |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Messaging     |    Version:
 Severity:  major         |   Keywords:
--------------------------+-----------------------------
 Not sure why this is occurring (BP 1.6), but sending reply to a message
 results in undefined index 'subject' in bp-messages-actions.php line 35.


 line 35 checks for a $_POST['subject']

     if ( messages_new_message( array( 'thread_id' => $thread_id, 'subject'
 => $_POST['subject']

 /single/messages/single.php sends no 'subject'

     <input type="hidden" id="thread_id" name="thread_id" value="<?php
 bp_the_thread_id(); ?>" />
     <input type="hidden" id="messages_order" name="messages_order"
 value="<?php bp_thread_messages_order(); ?>" />


 To correct this pro tem I've had to add:


     <input type="hidden" id="thread_subject" name="subject" value="<?php
 bp_the_thread_subject() ?>" />


 Haven't tested earlier versions, but checked the two files in 1.5.3.1 and
 they appear same as 1.6

 Feel as though I've overlooked something somewhere

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4225>
BuddyPress <http://buddypress.org/>
BuddyPress