[buddypress-trac] [BuddyPress] #4061: Member count in Members Directory 'All Members' tab is incorrect

[buddypress-trac at lists.automattic.com]

#4061: Member count in Members Directory 'All Members' tab is incorrect
--------------------------+-----------------------------
 Reporter:  boonebgorges  |      Owner:  boonebgorges
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Members       |    Version:
 Severity:  normal        |   Keywords:  2nd-opinion
--------------------------+-----------------------------
 The member count in the 'All Members' tab does not match the count in the
 pagination numbers below. The reason is this: the tab count traces back to
 the function bp_core_get_total_member_count(), which does a true count of
 rows in wp_users. However, our BP members queries join against wp_usermeta
 for the last_activity meta item, and thus do not return members who do not
 have a last_activity meta set. Something should be done to make these
 numbers match.

 One possibility is to change BP so that we don't require last activity.
 This is not viable: among other things, this would break multi-network
 installations of BP, which keep their member directories separate by
 exploiting prefixed last_activity usermeta.

 I don't think we should go changing what bp_core_get_total_member_count()
 queries, because there are probably plugins (and maybe even places in BP)
 where it's being exploited for its current behavior.

 So I think the best bet is to introduce a separate set of functions for
 getting the number of BP-recognized users, which will return the same
 value as the members queries. I'll write the patch, but first I wanted to
 make sure there were no objections.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4061>
BuddyPress <http://buddypress.org/>
BuddyPress