[buddypress-trac] [BuddyPress] #4222: Deleting Comment with @mention Resends Notification

[buddypress-trac at lists.automattic.com]

#4222: Deleting Comment with @mention Resends Notification
----------------------------+------------------
 Reporter:  SlothLoveChunk  |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  1.6
Component:  Notifications   |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |
----------------------------+------------------

Comment (by boonebgorges):

 > I hate to ask, but are you sure your dev environment is set up to send
 emails via SMTP?

 It's set up to send with standard wp_mail(), which uses PHP's mail(). In
 any case, other emails are successfully being sent by my system, so that
 can't be an issue.

 > could this issue possibly manifest itself in
 bp_activity_at_name_filter()?

 That's part of the chain, but I doubt it's part of the problem. Inside of
 `bp_activity_at_name_filter()`, you'll see that notifications are only
 sent if an `$activity_id` has been passed to the function. The function is
 called in a variety of places through BP, but the only place where
 `$activity_id` is passed is in `bp_activity_at_name_filter_updates()`.
 `bp_activity_at_name_filter_updates()`, in turn, is only fired at the
 'bp_activity_after_save' action. This suggests that when you delete the
 comment, an activity item is being saved, which should not be happening.
 This is why a stack track would help us figure out what's going on.

 I don't know how to use xdebug or breakpoints in Netbeans. A google search
 will probably tell you. Something very simple you can do is to put manual
 breakpoints or error_log() at strategic places right in the codebase. For
 instance, you might try something like the following, just before the
 activity item is saved in bp_activity_add():

 {{{
 foreach( (array) $activity as $key => $value ) {
     error_log( $key . ': ' . $value . "
 " );
 }
 }}}

 Then delete a comment and trail your error log. You should be able to see
 the item that is being saved, which will give a clue to what's happening.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4222#comment:8>
BuddyPress <http://buddypress.org/>
BuddyPress