[buddypress-trac] [BuddyPress] #4339: Repeat footer - eq4.us
buddypress-trac at lists.automattic.com
buddypress-trac at lists.automattic.com
Tue Jul 10 16:50:52 UTC 2012
#4339: Repeat footer - eq4.us
-------------------------------------------------+-------------------------
Reporter: rbasmaji | Owner:
Type: defect (bug) | johnjamesjacoby
Priority: normal | Status: assigned
Component: Theme | Milestone: Awaiting
Severity: normal | Review
Keywords: needs-patch needs-testing dev- | Version: 1.6-beta
feedback | Resolution:
-------------------------------------------------+-------------------------
Comment (by boonebgorges):
`did_action()` is a good idea, though ideally we would always demur in
favor of the hardcoded template-level do_action(). `did_action()` will
only work if `wp_footer()` is called *after* `do_action( 'bp_footer' )` is
called in the template. This is the case in bp-default 1.5.x
https://buddypress.trac.wordpress.org/browser/branches/1.5/bp-themes/bp-
default/footer.php, which should mean that the majority of child themes
are doing it in this order too. Still, there may be themes that have
switched it around, and `did_action()` won't help them.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4339#comment:13>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list