[buddypress-trac] [BuddyPress] #4332: Trouble with ajax favoriting activities if different than activity_updates

[buddypress-trac at lists.automattic.com]

#4332: Trouble with ajax favoriting activities if different than activity_updates
--------------------------+-----------------------
 Reporter:  imath         |       Owner:
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  1.6
Component:  Theme         |     Version:  1.6-beta
 Severity:  normal        |  Resolution:  fixed
 Keywords:  commit        |
--------------------------+-----------------------

Comment (by boonebgorges):

 johnjamesjacoby - Thanks for the reminder about BPTP. In this case, it
 shouldn't affect anything. The PHP change is not at the template level; as
 long as templates use bp_activity_css_class() (which BPTP templates do),
 they'll get the new class name. For the past year or so, BPTP has been set
 up to load its javascript directly from bp-default, which means that it
 will automatically inherit the JS-level change.

 The only potential problems are where someone has modified their template
 so as not to use bp_activity_css_class(). But this would probably cause
 lots of JS problems beyond what's described here, and there's only so much
 we can do to support non-standard markup with bp-default JS.

 But you're very correct that we should emphasize this kind of change in
 release notes, especially for people rolling very customized themes that
 are based on bp-default.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4332#comment:8>
BuddyPress <http://buddypress.org/>
BuddyPress