[buddypress-trac] [BuddyPress] #4335: Activity stream "everything" filter assumes Groups component is active

[buddypress-trac at lists.automattic.com]

#4335: Activity stream "everything" filter assumes Groups component is active
--------------------------+-----------------------
 Reporter:  DJPaul        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  1.6
Component:  Core          |     Version:  1.6-beta
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------
Changes (by boonebgorges):

 * keywords:   => has-patch


Comment:

 Let's try to get closer to the root of the problem. The fatal error arises
 because we're calling `groups_get_group()` when the groups component is
 disabled. So let's check for groups before calling that function. See
 4335.02.patch. There should be no backward compatibility issues with this.

 Third-party components take care of themselves automatically on
 deactivation. Our problem arises because we are making a function call to
 a function that does not exist. Plugins that attach themselves with action
 and filter hooks can't have this problem, since they won't be around
 anymore to call the non-existent functions. This is simply a case of BP's
 component leeching into each other in an abusive, privileged way (which is
 to say that, down the road, this sort of thing should be handled on a
 component-specific basis, where there's an `apply_filters()` on `$alt`,
 which can be filtered in the groups component.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4335#comment:4>
BuddyPress <http://buddypress.org/>
BuddyPress