[buddypress-trac] [BuddyPress] #4332: Trouble with ajax favoriting activities if different than activity_updates

[buddypress-trac at lists.automattic.com]

#4332: Trouble with ajax favoriting activities if different than activity_updates
--------------------------+-----------------------
 Reporter:  imath         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  1.6
Component:  Theme         |     Version:  1.6-beta
 Severity:  normal        |  Resolution:
 Keywords:  dev-feedback  |
--------------------------+-----------------------
Changes (by boonebgorges):

 * keywords:   => dev-feedback
 * milestone:  Awaiting Review => 1.6


Comment:

 Good find.

 The change away from the parent() walker was made so that the bp-default
 javascript would be a bit more forgiving of modifications in the structure
 of child theme templates. See #3821, r5998. So I would like to avoid
 switching back to this method.

 In theory, I prefer your suggested method (1) - add a generic activity-
 item class to *all* activity items, and then look for the closest one of
 those. This would provide the most flexibility going forward. However,
 this has the possibility of breaking child themes, at least those that are
 bypassing `bp_activity_css_class()` and rolling their own classes. That
 said, I'm certain that only a very small number of themes fall into this
 category, and anyway, even if the AJAX breaks, favoriting still works
 properly (it submits a form request and reloads the page). So if it breaks
 in a child theme, it will do so pretty gracefully.

 Can I get feedback from another core dev?

 [Side note for imath: Thanks for attaching diff files. In the future, you
 can make it even easier for us if you create your diff from the root of
 your BP plugin directory, which should capture changes in the entire BP
 codebase in a single diff.]

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4332#comment:1>
BuddyPress <http://buddypress.org/>
BuddyPress