[buddypress-trac] [BuddyPress] #4222: Deleting Comment with @mention Resends Notification

[buddypress-trac at lists.automattic.com]

#4222: Deleting Comment with @mention Resends Notification
--------------------------------------------+-----------------------
 Reporter:  SlothLoveChunk                  |       Owner:
     Type:  defect (bug)                    |      Status:  new
 Priority:  normal                          |   Milestone:  1.6
Component:  Notifications                   |     Version:  1.6-beta
 Severity:  normal                          |  Resolution:
 Keywords:  has-patch needs-testing commit  |
--------------------------------------------+-----------------------
Changes (by boonebgorges):

 * keywords:  has-patch needs-testing => has-patch needs-testing commit


Comment:

 DJPaul - 4222.02 is not very elegant, but at least it is generalizable
 (deleting activity, editing via Activity Management panel, Akismet
 management, etc). A non-hackish solution would involve moving the
 notification bits out of the mention-recount function, so that the
 notification function could be called conditionally, but this would
 involve a fairly major rethinking of the way @-mentions are detected and
 counted. This is way more than what we should do for now. And we can
 always do this refactoring in the future and keep the proposed filter for
 backpat. So I say let's go with it.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4222#comment:21>
BuddyPress <http://buddypress.org/>
BuddyPress