[buddypress-trac] [BuddyPress] #4039: Blog comments link to a user's activity via the same email address, regardless of it being them or not
buddypress-trac at lists.automattic.com
buddypress-trac at lists.automattic.com
Thu Feb 23 22:09:37 UTC 2012
#4039: Blog comments link to a user's activity via the same email address,
regardless of it being them or not
-------------------------+-----------------------------
Reporter: mdpane | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Core | Version: 1.5.4
Severity: normal | Resolution:
Keywords: 2nd-opinion |
-------------------------+-----------------------------
Changes (by boonebgorges):
* keywords: => 2nd-opinion
* milestone: Awaiting Review => Future Release
Comment:
Good observation, but I don't know if this is a feature or a bug. The same
thing is true of the use of Gravatar.
The only thing I'd consider doing in BP is changing this around a little
bit:
http://buddypress.trac.wordpress.org/browser/tags/1.5.4/bp-blogs/bp-blogs-
functions.php#L238
Add a switch so that we first look for bp_loggedin_user_id() before doing
a get_user_by( 'email' ) lookup, and add a filter so that the admin can
prevent the get_user_by('email') lookup for non-logged-in members. That
way admins can decide on a case-by-case basis whether to allow non-logged-
in activity tracking.
Second opinion?
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4039#comment:2>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list