[buddypress-trac] [BuddyPress] #4060: Improve performance of BP_Core_User::get_users()

buddypress-trac noreply at wordpress.org
Sat Dec 15 17:13:01 UTC 2012


#4060: Improve performance of BP_Core_User::get_users()
---------------------------------------------+---------------------------
 Reporter:  shanebp                          |       Owner:  boonebgorges
     Type:  enhancement                      |      Status:  assigned
 Priority:  highest                          |   Milestone:  1.7
Component:  Members                          |     Version:  1.2.9
 Severity:  critical                         |  Resolution:
 Keywords:  needs-testing reporter-feedback  |
---------------------------------------------+---------------------------

Comment (by boonebgorges):

 (In [6638]) In BP_User_Query, only parse the 'user_id' param if 'include'
 is empty

 Friend request queries work by passing a list of requests to the 'include'
 parameter of bp_has_members(). This conflicts necessarily with doing a
 'user_id' check in BP_User_Query, because 'user_id' limits results to the
 passed user's friends (which are, by definition, different from his friend
 requests). Thus, when an 'include' param is passed, the 'user_id' check
 should
 be skipped.

 This replicates the same logic in BP_Core_User::get_users().

 See #4060

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4060#comment:52>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list