[buddypress-trac] [BuddyPress] #2945: Don't hard-code the 'buddypress' plugin folder

[buddypress-trac at lists.automattic.com]

#2945: Don't hard-code the 'buddypress' plugin folder
--------------------------+-----------------------------
 Reporter:  cnorris23     |       Owner:
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  Future Release
Component:  Core          |     Version:  1.6
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |
--------------------------+-----------------------------

Comment (by cnorris23):

 Replying to [comment:25 foxly]:
 My original reply to this was incredibly long and snarky, so in the
 interest of the community, I've chosen to only respond directly to the
 statement directed towards me.
 > Some users on this ticket seem to be misinterpreting the WP codex
 article to mean "users should be able to rename an individual plugin's
 install folder".
 >
 > This is NOT what the codex says.
 >
 > The codex says "users should be able to rename the ROOT plugins folder
 and install their WP installation to an arbitrary location on the server".
 >
 > They're completely different things.
 You're right. They are completely different things. However, if you'd like
 to call me out, please do so directly, rather than passive aggressively
 saying "some users," and also make sure that you have thoroughly
 read/interpreted what was said. To quote myself "According to Determining
 Plugin and Content Directories, the way BP currently handles this is
 minimal, but sufficient." As said in the statement, BuddyPress was doing
 things minimally correct, as it wasn't hard coding the root plugin
 directory, or the wp-content directory locations. However, I said
 minimally correct, because to fully comply with, and use, the WP API,
 plugins should be using plugins_url(), plugin_dir_url(), and
 plugin_dir_path() (or at least mimicking their functionality), which
 allows these paths and URLs to be dynamically created using only the
 {{{__FILE__}}} constant as a reference. The changes proposed by this
 ticket, and the changes already committed, do nothing different than what
 is already being done by the majority of actively maintained plugins in
 the WP plugin directory (reasonable guess), and what is purported by the
 WP API itself. This includes such plugins as Akismet, bbPress, and BP
 Media. How did Akismet and BP Media, who both have unit tests available,
 account for the possibility of users changing the plugin folder name?
 Simple. They didn't, nor should they.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/2945#comment:26>
BuddyPress <http://buddypress.org/>
BuddyPress