[buddypress-trac] [BuddyPress] #4456: BP_XProfile_Group->get() does not return default field visibility on register.php

[buddypress-trac at lists.automattic.com]

#4456: BP_XProfile_Group->get() does not return default field visibility on
register.php
--------------------------+-----------------------------
 Reporter:  drkane        |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  XProfile      |    Version:  1.6
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 When a user is presented with the registration form through register.php,
 the "this field can be seen by:" label always reads "Anyone" no matter
 what the field visibility setting is.

 This is because when the field settings are found through the
 BP_XProfile_Group class's "get" function, the default field visibility
 variable is not fetched. This is because the user_id of the displayed user
 is set to 0 (as there is no displayed user in this case), so
 {{{
 if ( ! empty( $fetch_field_data ) && ! empty( $user_id ) )
 }}}
 (on line 178) is false, and the command to fetch field visibility is not
 triggered.

 My quick fix was to remove the check on user_id in the if statement, but
 presumably this is needed for other uses of this function.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4456>
BuddyPress <http://buddypress.org/>
BuddyPress