[buddypress-trac] [BuddyPress] #3797: Refactor database methods to accept array-style arguments

[buddypress-trac at lists.automattic.com]

#3797: Refactor database methods to accept array-style arguments
------------------------------------+------------------
 Reporter:  boonebgorges            |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  1.6
Component:  Core                    |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+------------------

Comment (by r-a-y):

 Gigantic +1!

 I just tested 02.patch lightly by using the old constructor arguments and
 it works well.

 I only have one small tidbit for the PHP notice.

 The full PHP notice currently reads like this:

 `PHP Notice:  BP_Activity_Template::__construct was called with an
 argument that is <strong>deprecated</strong> since version 1.6! Arguments
 passed to BP_Activity_Template::__construct should be in an associative
 array. See the inline documentation for more details. in \PATH\wp-
 includes\functions.php on line 3551`

 The `wp-includes/functions.php` part can throw some people off.

 Perhaps amend line 115 in 02.patch from:

 `Arguments passed to %s should be in an associative array. See the inline
 documentation for more details.`

 to:

 `Arguments passed to %s should be in an associative array. View the inline
 documentation in /bp-activity/bp-activity-classes.php for more details.`

 Other than that, great job, Boone!

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3797#comment:8>
BuddyPress <http://buddypress.org/>
BuddyPress