[buddypress-trac] [BuddyPress] #4139: bp_core_get_root_options() overwriting blog options on certain setups

[buddypress-trac at lists.automattic.com]

#4139: bp_core_get_root_options() overwriting blog options on certain setups
--------------------------+-----------------------------
 Reporter:  boonebgorges  |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Core          |    Version:
 Severity:  major         |   Keywords:
--------------------------+-----------------------------
 bp_core_get_root_options() was recently refactored (see
 https://buddypress.trac.wordpress.org/changeset/4587,
 https://buddypress.trac.wordpress.org/ticket/3313) to be better at
 migration when changing settings. However, the logic for migrating these
 settings was a bit greedy: if even a single option is found missing in the
 current root_blog's options table, then *all* of the options get copied
 over from a previous location (sitemeta, etc).

 This has the side effect that some changes are perpetually overwritten. As
 an example, I discovered this issue in the process of troubleshooting an
 issue with `bp-xprofile-fullname-field-name` - I kept changing the name of
 the field itself in the Dashboard, but the option `bp-xprofile-fullname-
 field-name` kept sticking to an old value.

 I'm going to commit a fix that takes the following strategy: in cases
 where the relevant options are found on the current root_blog, keep them -
 only attempt to migrate *missing* settings.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4139>
BuddyPress <http://buddypress.org/>
BuddyPress