[buddypress-trac] [BuddyPress] #3797: Refactor database methods to accept array-style arguments

[buddypress-trac at lists.automattic.com]

#3797: Refactor database methods to accept array-style arguments
------------------------------------+-----------------------------
 Reporter:  boonebgorges            |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  Future Release
Component:  Core                    |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+-----------------------------
Changes (by boonebgorges):

 * keywords:  needs-patch dev-feedback => dev-feedback has-patch


Comment:

 Based on a bit of feedback from DJPaul, here is a shot at a refactor, this
 time expanded for the entire `bp_has_activities()` stack
 ({{{BP_Activity_Template::__construct()}}},
 {{{BP_Activity_Activity::get()}}}, and all the places where these methods
 are referenced, except for the deprecated
 {{{BP_Activity_Activity::get_specific()}}})

 Note that I have abstracted out the utility function
 `bp_core_parse_args_array()`. Writing documentation for this function that
 makes sense was the hardest part of writing this patch :)

 Feedback/tests welcome. If all are happy with this approach, I'll put
 these particular changes in right now, and we can roll the changes across
 BP more generally either now or in the next dev cycle. Thanks.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3797#comment:6>
BuddyPress <http://buddypress.org/>
BuddyPress