[buddypress-trac] [BuddyPress] #3630: Date Selector Bug

[buddypress-trac at lists.automattic.com]

#3630: Date Selector Bug
-----------------------+--------------------
 Reporter:  ken_k      |       Owner:
     Type:  defect     |      Status:  new
 Priority:  normal     |   Milestone:  1.5.1
Component:  Core       |     Version:  1.5
 Severity:  minor      |  Resolution:
 Keywords:  has-patch  |
-----------------------+--------------------
Changes (by boonebgorges):

 * keywords:   => has-patch


Comment:

 3630.01.patch is a quick fix. It does two things:
 - Switches isset() to !empty(). Previously, isset() always returned true,
 because the submitted dropdown passed an empty string as the value.
 - Checks to see that day, month, and year are all filled out, instead of
 just the day. Since we are setting the saved value using date(), we really
 should be requiring all three fields anyway. (I think there is a good
 argument for *not* requiring all three fields, but that would require a
 different method for saving stuff, and would be a future enhancement.)

 If people are cool with this fix, I'll copy the logic over to the profile
 edit functions too (they're processed separately from registration
 fields).

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3630#comment:2>
BuddyPress <http://buddypress.org/>
BuddyPress