[buddypress-trac] [BuddyPress] #3389: Enqueueing CSS of bp-default breaks child theme layouts
buddypress-trac at lists.automattic.com
buddypress-trac at lists.automattic.com
Mon Sep 5 16:40:28 UTC 2011
#3389: Enqueueing CSS of bp-default breaks child theme layouts
-----------------------+------------------
Reporter: mercime | Owner:
Type: defect | Status: new
Priority: normal | Milestone: 1.5
Component: Theme | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-----------------------+------------------
Comment (by boonebgorges):
Here's another idea: Enqueue the child theme's stylesheet as dependent on
bp-default-main, and then enqueue bp-default-main. See 3384.05.patch.
This provides full backpat with existing @include methods. The big
downside is that, in cases where @include is used, we request default.css
twice.
But: is this that big a deal? Going forward, we can recommend that themes
either leave out the @import rule, or override bp_dtheme_enqueue_styles(),
or both. When you do either of those things, the duplicate HTTP request
disappears. Themes that are not updated will just be a little inefficent.
(But even then, given the aggressive way in which browsers cache
stylesheets, it seems pretty negligible.)
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3389#comment:47>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list