[buddypress-trac] [BuddyPress] #3595: Menu still not working with 1.5 and IE7
buddypress-trac at lists.automattic.com
buddypress-trac at lists.automattic.com
Fri Oct 7 20:04:39 UTC 2011
#3595: Menu still not working with 1.5 and IE7
---------------------------+--------------------
Reporter: blogsterfiles | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 1.5.1
Component: Theme | Version: 1.5
Severity: major | Resolution:
Keywords: has-patch |
---------------------------+--------------------
Comment (by boonebgorges):
Oh, cool. I have tested 01.patch on a slew of browsers and it all looks
good to me.
Not sure what to say about the #navigation height issue. I'm sure it will
affect at least some child themes. The change means that the vertical
space between the tabs and the search box is dictated by the height of the
#navigation element rather than the top margin on #nav (you can change
40px to whatever you want since it's now absolutely positioned). That
seems like a pretty significant change the way that the layout is
determined. And the switch to absolute positioning seems like a change for
the worse.
So. A couple questions.
- How committed are we to IE7 support? Enough to make a significant CSS
change mid-cycle, just to support it?
- Are there other approaches? Seems like the root of the problem is
display: inline-block on #nav li, which IE7 doesn't know what to do with.
It's possible that we could work around this with some browser hacks in
our existing stylesheet (see eg http://grasshopperpebbles.com/css/css-
inline-block-ie7-hack/), or with a conditionally loaded < IE7 stylesheet.
Both of these options are icky in themselves, of course, but is it worth
considering the trade-offs?
- Am I overreacting to r-a-y's proposed change? I'm not much of a front-
end guy, maybe I'm making a mountain out of a molehill and we should just
go with his proposal :)
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3595#comment:14>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list