[buddypress-trac] [BuddyPress] #3463: After a hidden group is made public all activity is still hidden

[buddypress-trac at lists.automattic.com]

#3463: After a hidden group is made public all activity is still hidden
--------------------------+------------------
 Reporter:  modemlooper   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  1.6
Component:  Core          |     Version:  1.5
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------

Comment (by boonebgorges):

 I've been thinking some more about this, and I don't have a solution in
 mind, but I do have some thoughts:

 - modemlooper is right that this is something that needs to be fixed. As
 it stands, once the group has been made public, old activity is invisible
 to everyone, which seems plainly wrong.
 - Here http://buddypress.trac.wordpress.org/browser/trunk/bp-activity/bp-
 activity-template.php#L270 (line 275) is the source of the issue.

 One suggestion is in 3463.01.patch. Essentially, show_hidden is true when
 users are members of the group, even in public groups. The upside of this
 solution is that we don't have to loop through existing activity and set
 hide_sitewide (which would be a nightmare on several levels). The downside
 is that it makes the activity stream of a "public" group look different to
 members and non-members, which seems not quite "public". Of course, since
 most groups will start public and remain public - and thus all of their
 activity will have hide_sitewide = false - it's an edge case at best.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3463#comment:4>
BuddyPress <http://buddypress.org/>
BuddyPress