[buddypress-trac] [BuddyPress] #3754: Drop support for 'afilter'

[buddypress-trac at lists.automattic.com]

#3754: Drop support for 'afilter'
--------------------------+-----------------------------
 Reporter:  boonebgorges  |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Activity      |    Version:  1.2.10
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 I ran across an ugly problem recently related to the old 'afilter' URL
 param for bp-activity. A single spam blog comment was left on one of the
 sites of a MS network, and, because of a plugin the site was using, it got
 included in the activity stream. But a glitch in the way that afilter is
 processed meant that when you attached an afilter argument to any activity
 page on the site - including the activity streams of individual members -
 the user_id and other activity filter parameters are skipped, and the spam
 activity comment was showing up under these circumstances for every user
 of the site. This didn't matter for normal users, but somehow Google's
 crawlers picked up on it, and got the site tagged as a spam farm, since
 the same spam comment was showing up hundreds of times across the site.

 The offending logic is here:
 http://buddypress.trac.wordpress.org/browser/trunk/bp-activity/bp-
 activity-template.php#L377

 Can we just drop the first clause?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3754>
BuddyPress <http://buddypress.org/>
BuddyPress