[buddypress-trac] [BuddyPress] #3731: Language of titles

[buddypress-trac at lists.automattic.com]

#3731: Language of titles
--------------------------+--------------------
 Reporter:  RuBAN-GT      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  1.5.2
Component:  Core          |     Version:
 Severity:  major         |  Resolution:
 Keywords:                |
--------------------------+--------------------
Changes (by boonebgorges):

 * milestone:  Awaiting Review => 1.5.2


Comment:

 Thanks for the patches.

 We shouldn't be putting dynamic content through the {{{__()}}} translation
 function. That function should only take hardcoded strings, as otherwise
 it will be impossible to create generic .pot files for translators. This
 means that your particular suggestions won't work (eg, {{{__(
 bp_get_name_from_root_slug(), 'buddypress' )}}})

 That said, your third fix passes the value of bp_get_name_from_root_slug()
 to the translation function, which is possibly correct (since
 bp_get_name_from_root_slug() returns the component name, which is
 hardcoded into the component loader). I'll have to test.

 I generally run the French translation and have not noticed any problems
 with these titles. No ya govaryu nemnozhko po russki, so I'll download the
 Russian translation pack sometime this week and see if I can reproduce
 your issues.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3731#comment:2>
BuddyPress <http://buddypress.org/>
BuddyPress