[buddypress-trac] [BuddyPress] #3246: Bringing back bp_core_catch_no_access()

[buddypress-trac at lists.automattic.com]

#3246: Bringing back bp_core_catch_no_access()
------------------------------------+-----------------------------
 Reporter:  r-a-y                   |      Owner:
     Type:  defect                  |     Status:  new
 Priority:  normal                  |  Milestone:  Awaiting Review
Component:  Core                    |    Version:  1.3
 Keywords:  has-patch dev-feedback  |
------------------------------------+-----------------------------
 The following patch brings back '''bp_core_catch_no_access()''' to v1.3, a
 vital function [http://buddypress.trac.wordpress.org/browser/tags/1.2.8
 /bp-core/bp-core-catchuri.php#L249 from v1.2] that did a number of things:

 - Redirect spammer profiles to root for logged-in users who are not super
 admins.
 - Redirect users who do not exist to root (will fix #3176)
 - Access control for items that require authentication (code existed, but
 did not work - see #2647)

 ---

 Also included in the patch is a new function - bp_core_no_access() - which
 adds an error message (if one is provided) and redirects the user to
 login.

 I threw some ideas at Boone for this function and he wanted to see
 redirects to $bp->root_domain so users can login with the sidebar widget,
 while I wanted to keep the existing functionality -
 [http://buddypress.trac.wordpress.org/browser/tags/1.2.8/bp-core/bp-core-
 catchuri.php#L281 authenticating from wp-login.php].  The end result is a
 compromise via the "mode" parameter.

 Boone's issue was with branding.

 My main issue with redirecting to $bp->root_domain is not every one will
 be using bp-default and bp-default's sidebar login block.  For example,
 those using BP Template Pack would be redirected to root with nowhere to
 login, unless you filter the $root variable.  So I would suggest having
 the "mode" parameter default to 2.

 ---

 In order to test with private / hidden group activity updates, you'll need
 to apply patch #2579 or #3210.

 Those patches will also need to replace instances of
 {{{
 bp_core_redirect( site_url( 'wp-login.php?redirect_to=... ) )
 }}}
 with bp_core_no_access() as well.

-- 
Ticket URL: <https://trac.buddypress.org/ticket/3246>
BuddyPress <http://buddypress.org/>
BuddyPress