[buddypress-trac] [BuddyPress] #3095: Change password form to send via SSL?

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Thu Mar 3 19:49:18 UTC 2011


#3095: Change password form to send via SSL?
---------------------+-----------------------------
  Reporter:  finni3  |      Owner:
      Type:  defect  |     Status:  new
  Priority:  normal  |  Milestone:  Awaiting Review
 Component:  Core    |    Version:  1.2.8
Resolution:          |   Keywords:  dev-feedback
---------------------+-----------------------------
Changes (by r-a-y):

 * keywords:  ssl => dev-feedback
 * version:   => 1.2.8


Comment:

 In BP 1.2x, the form action uses $bp->loggedin_user->domain to output the
 URL.
 $bp->loggedin_user->domain can be routed upstream to
 bp_core_get_user_domain().

 bp_core_get_user_domain(), in turn, uses get_blog_option( $blog_id, 'home'
 ).

 ---

 BP 1.3 fixes this as bp_core_get_user_domain() uses get_home_url(), which
 appropriately trigger the URL to use SSL if it is enabled:
 http://codex.wordpress.org/Function_Reference/get_home_url

 ---

 Another way around the problem is to leave form actions blank (if it's not
 a multipart form) so they refresh on the same page.

 Need core dev feedback on this though.

-- 
Ticket URL: <https://trac.buddypress.org/ticket/3095#comment:1>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list