[buddypress-trac] [BuddyPress] #3253: Move activity reply HTML to template.

[buddypress-trac at lists.automattic.com]

#3253: Move activity reply HTML to template.
--------------------------+-----------------------
  Reporter:  r-a-y        |      Owner:
      Type:  enhancement  |     Status:  new
  Priority:  normal       |  Milestone:  1.3
 Component:  Activity     |    Version:  1.2
Resolution:               |   Keywords:  has-patch
--------------------------+-----------------------

Comment (by boonebgorges):

 Thanks for your investigations, all!

 Re multiple IDs: If I'm reading the JS correctly, it's *moving* the
 existing form, not creating a new one. So there aren't really any
 duplicates.

 Dennissmolek:
 > I want to also so that while doing all these testing I found it annoying
 that when replying to comment 2, I have to go past comment 5 to get to the
 form.
 The idea here is that when you have activity item A with comments 1, 2, 3,
 and 4, you should have to go to the end of all of those comments before
 posting a reply. This seems no different from blog comments.

 I was going to move the markup out of ajax.php and use the new template,
 but that's going to be harder than I thought, because of the way the
 markup is currently generated (using bp_has_activities() and the regular
 activity template tags). Some structural changes will have to be made to
 make it work. I'll open a separate ticket for it once this change has been
 committed.

 r-a-y:
 > Boone, 3253.1.diff needs a conditional check to use the old activity
 comments code if BP can't locate the new activity comment template.
 Otherwise, activity comments will break for existing BP themes.

 Since I'm using locate_template(), this is only true for themes that are
 not children of bp-default. But you're right. So I changed the logic a
 little, and added a conditional check, so that if the template is not
 found in the theme (or its parent), it'll be loaded directly out of bp-
 default. See 3253.3.diff

 3253.3.diff also adds PHPDoc.

-- 
Ticket URL: <https://trac.buddypress.org/ticket/3253#comment:24>
BuddyPress <http://buddypress.org/>
BuddyPress