[buddypress-trac] [BuddyPress] #3261: BP options get/update wrapper functions
buddypress-trac at lists.automattic.com
buddypress-trac at lists.automattic.com
Tue Jun 7 14:01:25 UTC 2011
#3261: BP options get/update wrapper functions
---------------------------+-----------------
Reporter: boonebgorges | Owner:
Type: defect | Status: new
Priority: normal | Milestone: 1.3
Component: Core | Version:
Resolution: | Keywords:
---------------------------+-----------------
Comment (by boonebgorges):
Replying to [comment:11 wpmuguru]:
> I think it would create lots of forum threads if those could be turned
on and off on a per site basis. Currently those settings are network wide
when BP_ENABLE_MULTIBLOG is set.
Right. This seems like it's probably the correct behavior for
BP_ENABLE_MULTIBLOG. But it's definitely not the right behavior for
multinetwork. I guess I was thinking that it would make sense to be
consistent across data types, but since pre_site_option_ is available,
it's probably better not to overengineer.
If the only thing that needs to be site-specific is bp-pages, then this is
already done. bp-pages data is stored in a site_option, which is an array
keyed by blog_id. You'll need to apply the patch 3219.2.patch from #3219
to see how it works (that patch puts BP options on the blog Dashboard,
rather than Network Admin, when BP_ENABLE_MULTIBLOG is enabled, so that
you get the 'you have components with no WP pages' admin notice on
secondary blogs). That means that, once #3219 is fixed, and the bp-multi-
network patch has filtered 'bp_core_do_network_admin' to return false,
then the bp-pages part should just work automatically.
If those two things are true (that bp-pages works on a per-blog basis when
#3219 is fixed, and that pre_site_option_ is an acceptable way to filter
other site options if desired), then we can probably close this ticket as
rejected.
--
Ticket URL: <https://trac.buddypress.org/ticket/3261#comment:12>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list