[buddypress-trac] [BuddyPress] #3265: bp-default - move sidebar to footer
buddypress-trac at lists.automattic.com
buddypress-trac at lists.automattic.com
Fri Jun 3 15:11:30 UTC 2011
#3265: bp-default - move sidebar to footer
--------------------------+-----------------------------
Reporter: svenl77 | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Theme | Version: 1.3
Resolution: | Keywords: bp-default
--------------------------+-----------------------------
Comment (by svenl77):
It has nothing to do with switching from right to left.
I will give some examples:
If I have a left and right sidebar, and I want to turn off the right
sidebars in groups, but keep the widgets from the left sidebar, css
wouldn't work.
Also if I have a theme option page to turn off the right sidebar, the
option wouldn't work in template files from other plugins which extends
for example the groups. If I go to the new group component the component
template is loaded. The plugins are based on the bp-default, and so they
add the sidebar. My theme option will not work.
I think if the bp-default changes and moves the sidebar in the footer,
many plugin authors would delete the sidebar out of the template files.
If you like to have no sidebars in your theme, this would be difficult
too.
Or even if you want to have only a left sidebar and your theme has already
integrated a left sidebar. You will run into trouble.
This is actually another ticket, but in the default theme there is a hard
coded login widget in the right sidebar.
If I switch from right to left via css, I would stuck with the login
widget. I believe this should be a real widget.
I also do not feel comfortable to add the sidebar to the footer.
But to be honest I think actually Buddypress shouldn't add sidebars at
all.
This patch is just for 1.3, as I hope it will make theme design for non
BuddyPress lovers more easy, and more people start building their own
themes.
In future releases, I hope the BuddyPress theme will change to come
without sidebars, header and footer and just add content loop templates
and widgets. But for now, I believe moving the sidebar into the footer
would make it more easy.
--
Ticket URL: <https://trac.buddypress.org/ticket/3265#comment:2>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list