[buddypress-trac] [BuddyPress] #3243: CSS files need commenting and organisation
buddypress-trac at lists.automattic.com
buddypress-trac at lists.automattic.com
Thu Jun 2 10:32:06 UTC 2011
#3243: CSS files need commenting and organisation
--------------------------+------------------------
Reporter: karmatosed | Owner: karmatosed
Type: enhancement | Status: accepted
Priority: normal | Milestone: 1.3
Component: Theme | Version: 1.2
Resolution: | Keywords:
--------------------------+------------------------
Comment (by hnla):
> Right now, "Buttons" is above "Formatting" and the "Buttons" section
declares "a.button:hover". Since the top-level a:hover is below this,
a:hover's color will take precedence over what is declared for
a.button:hover.
@r-a-y sorry to highlight that struckthrough paragraph :) but in principle
this is correct, the more generic site wide applicable style would be
described first e.g a:hover this sets your general required styles then
later where required you would adjust this for something particular, this
honours the notion of the 'Cascade' even though later styles would infer a
heavier specificity through descendent selectors or classes.
Ok so in this instance things are not upset but the feel is wrong the
lesser weight declaration should precede more specific styles.
At the moment I'm still knee deep in trying to fathom the structure I like
and am partly hampered by the fact that I'm working things slightly arse
about face as I'm actively writing styles / rulesets then jumping back and
fourth re-structuring things as and when I realise something doesn't make
sense which is a horrendously slow process and far from ideal also I
don't want to conflict with Karmatosed's start on this which is overall
working out well.
If I can make a little more headway next two days in my actual structure (
I am also working to a slightly different approach with multi sheets,
separating framework structure out)I may post it for comparison.
Part of the reason I mentioned earlier the notion of using this exercise
as a starting point for setting out a new set of sheets and markup files
was due to there being some benefit to being able to start clean
describing the ideal structure and naming conventions for elements, an
exercise which I think would stand future possible bp-default themes and
also a base for using with custom themes in good stead, handy to have
ready to use.
--
Ticket URL: <https://trac.buddypress.org/ticket/3243#comment:33>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list