[buddypress-trac] [BuddyPress] #3243: CSS files need commenting and organisation

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Thu Jun 2 09:27:52 UTC 2011

#3243: CSS files need commenting and organisation
  Reporter:  karmatosed   |      Owner:  karmatosed
      Type:  enhancement  |     Status:  accepted
  Priority:  normal       |  Milestone:  1.3
 Component:  Theme        |    Version:  1.2
Resolution:               |   Keywords:

Comment (by hnla):

 @karmatosed Yep sounds good
 I'd written this before the last comment was made but was blocked due to
 changes, some of my comments might not pertinent now.''

 Elements is a very generic label though it doesn't really describe
 anything given everything could be labeled an element so to speak. 'Text
 Element' likewise, is somewhat loose?

  If one works to a conventional stylesheet approach it's usual to start
 the sheet off with all your site wide generic styles / typographic , that
 is heading sizes, margin defaults for primary block elements p. h# etc,
 anchor decs, and all the od tags like pre, blockquote, etc. I would argue
 that regardless of section name elements/text elements this section should
 really be towards the top of the sheet, under what ever this section is
 called I agree that 'headers' should be incorporated, the styles that are
 described are site wide generic, I don't think though that they need to be
 sub-sectioned as this is starting to over egg the pudding.

  I agree on the 'buttons' aspect although think they might be better in
 their own section? As Buttons stand they can exist as simple text links
 and outside of any form element so having them under '3.0 forms' doesn't
 feel correct.

  One thing I would comment on is to be wary of creating too complex a
 structure as that can start to become hard to navigate around and defeat
 the original intention, at least I found that to be true in running this
 same exercise myself with BP stylesheets.

Ticket URL: <https://trac.buddypress.org/ticket/3243#comment:31>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list