[buddypress-trac] [BuddyPress] #3414: Undefined index in BuddyBar

[buddypress-trac at lists.automattic.com]

#3414: Undefined index in BuddyBar
-----------------------------------------+-----------------------
 Reporter:  r-a-y                        |       Owner:
     Type:  defect                       |      Status:  reopened
 Priority:  normal                       |   Milestone:  1.5
Component:  Core                         |     Version:  1.5
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch reporter-feedback  |
-----------------------------------------+-----------------------

Comment (by boonebgorges):

 We don't use bp_core_remove_nav_item() internally, and we only use
 bp_core_remove_subnav_item() in an isolated incident where such a PHP
 notice would not arise. We provide them as convenience functions for
 plugin authors. And since the functions both take arbitrary string
 arguments, it's possible that the situation will arise where these isset()
 checks will be necessary.

 I'm assuming r-a-y was testing with some plugins that use the functions.
 r-a-y, can you confirm one way or the other?

 In any case, it's hard to see how these notices would signify any deeper
 problem in BP, since, as I say above, we don't use them.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3414#comment:4>
BuddyPress <http://buddypress.org/>
BuddyPress