[buddypress-trac] [BuddyPress] #3074: XProfile - Incorrect CSS zebra striping

[buddypress-trac at lists.automattic.com]

#3074: XProfile - Incorrect CSS zebra striping
-----------------------+-----------------------
 Reporter:  ezd        |       Owner:
     Type:  defect     |      Status:  reopened
 Priority:  normal     |   Milestone:  1.3
Component:  Theme      |     Version:  1.3
 Severity:  normal     |  Resolution:
 Keywords:  has-patch  |
-----------------------+-----------------------

Comment (by boonebgorges):

 Re 3074.04.patch. Your IS NOT NULL query assumes that blank rows in the
 profile data table for optional fields left blank. This may be the case
 during a normal profile edit (I would have to check) but it will not be
 the case if the admin creates a new profile field after the site is up and
 running. I'll grant that this is an edge case, and that your method is a
 bit easier to follow, but the method in 3074.03.patch does not have this
 shortcoming.

 Also, as DJPaul pointed out in a private channel, the static $alt_row; is
 unnecessary since the query won't be returning empty rows. We can use a
 modulo instead.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3074#comment:11>
BuddyPress <http://buddypress.org/>
BuddyPress