[buddypress-trac] [BuddyPress] #3375: Deprecated function call in bp-core-template.php

[buddypress-trac at lists.automattic.com]

#3375: Deprecated function call in bp-core-template.php
------------------------------------+------------------
 Reporter:  amereservant            |       Owner:
     Type:  defect                  |      Status:  new
 Priority:  normal                  |   Milestone:  1.3
Component:  Core                    |     Version:
 Severity:  major                   |  Resolution:
 Keywords:  needs-patch needs-docs  |
------------------------------------+------------------
Changes (by boonebgorges):

 * milestone:  Awaiting Review => 1.3


Comment:

 I'm the one who put the 'deprecated' idea into amereservant's head.
 bp_is_blog_page() is used in several places, but bp_is_root_component(),
 and the entire idea of $bp->root_components, is not. So, as you suggest
 DJPaul, bp_is_blog_page() should be reworked.

 The logical approach is to compare page ids against bp-pages, and return
 true if the page id doesn't appear in that list. The big problem with this
 approach, from what I can see, has to do with plugins that have top level
 nav items. Ideally, they should be registering themselves in bp-pages, but
 I do not believe that we have a natural way of doing that at the moment.
 Yet we still need a way for them to declare that they want their directory
 pages displayed as BP directories, not as WP content, which is the purpose
 of bp_is_blog_page().

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3375#comment:2>
BuddyPress <http://buddypress.org/>
BuddyPress