[buddypress-trac] [BuddyPress] #3340: Replace parentheses around nav item numbers with spans

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Sun Jul 17 23:55:26 UTC 2011

#3340: Replace parentheses around nav item numbers with spans
  Reporter:  davidtcarson  |      Owner:
      Type:  enhancement   |     Status:  new
  Priority:  normal        |  Milestone:  Awaiting Review
 Component:  Core          |    Version:  1.3
Resolution:                |   Keywords:

Comment (by DJPaul):

 I really like this patch, and it's very handy that you provided
 screenshots of the proposed change. Thank you, davidtcarson!

 I'm about to put it in, but thought I'd mention three changes I made.
 1) for the item-list-tabs CSS, I've added another selector so that the
 "blue" box changes to the same grey colour on mouseover as the other part
 of that link.
 2) I took out the line-height: 111% for the item-list-tabs as I'm wary of
 using line-height in this way, and because removing it didn't appear to
 have an impact on the theme.
 3) I took out the orange styles because those orange highlights were
 removed from the activity stream and blog comments after your patch was
 made :)

 If there was a good reason for that line-height which I've missed,
 davidtcarson, please let us know and we'll put it back. Thanks again.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3340#comment:2>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list