[buddypress-trac] [BuddyPress] #3059: Sticky topics get pushed to second page

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Thu Jul 7 23:35:29 UTC 2011

#3059: Sticky topics get pushed to second page
  Reporter:  boonebgorges  |      Owner:  sushkov
      Type:  defect        |     Status:  accepted
  Priority:  minor         |  Milestone:  1.4
 Component:  Forums        |    Version:
Resolution:                |   Keywords:  needs-patch
Changes (by boonebgorges):

 * milestone:  1.3 => 1.4


 sushkov - I'm sorry, I can't get this patch to work right. It's screwing
 up pagination pretty badly.

 I think that a proper patch will be quite difficult without some
 modifications to bbPress itself. In particular, when you have a page that
 contains non-sticky posts, it's almost possible to query those posts with
 BB_Query as it stands. What you really need is the ability to set an
 offset/number (rather than page/per_page) on BB_Query. See my attached
 bbpress-3059.1.diff to see what I mean. JJJ said he's happy to put a patch
 into bbPress if it makes our job easier.

 In any case, I spent about three hours on this today and didn't make much
 progress, so I'm giving up for the moment. If a site admin wants to have a
 separate sticky loop, with *separate* pagination, it's easy to do, and can
 be done at the theme level.

 sushkov, if you can provide a patch that paginates properly (on all
 different scenarios: different values for $_GET['n'] and $_GET['p']; # of
 stickies that is greater than $per_page; etc), we can move this back to
 the 1.3 milestone. Otherwise we'll try to get it in 1.3.1.


Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3059#comment:14>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list