[buddypress-trac] [BuddyPress] #3035: php notices after applying patch

[buddypress-trac at lists.automattic.com]

#3035: php notices after applying patch
--------------------------+-----------------------------
  Reporter:  jasonnathan  |      Owner:
      Type:  defect       |     Status:  new
  Priority:  normal       |  Milestone:  Awaiting Review
 Component:  Core         |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------------

Comment (by jasonnathan):

 Okay I found the problem in {{{bp_core_exclude_pages()}}} in bp-core-
 filters.php


 {{{
 if ( !bp_is_active( 'forums' ) || ( function_exists(
 'bp_forums_is_installed_correctly' ) &&
 !bp_forums_is_installed_correctly() ) )
                 $pages[] = $bp->pages->forums->id;
 }}}

 The condition is checking if the forums isn't active. Shouldn't it be
 checking is it is active?

 {{{
 if ( bp_is_active( 'forums' ) || ( function_exists(
 'bp_forums_is_installed_correctly' ) && bp_forums_is_installed_correctly()
 ) )
                 $pages[] = $bp->pages->forums->id;
 }}}

-- 
Ticket URL: <https://trac.buddypress.org/ticket/3035#comment:5>
BuddyPress <http://buddypress.org/>
BuddyPress