[buddypress-trac] [BuddyPress] #2600: WP pages as component slugs causes redirect problems

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Mon Jan 17 21:58:25 UTC 2011

#2600: WP pages as component slugs causes redirect problems
  Reporter:  boonebgorges  |      Owner:  boonebgorges
      Type:  defect        |     Status:  assigned
  Priority:  critical      |  Milestone:  1.3
 Component:  Activity      |    Version:
Resolution:                |   Keywords:

Comment (by boonebgorges):

 2600-4.patch is a patch that is more or less complete for the Groups and
 the Activity components. Begging for feedback :)

 I played around with our idea of setting the $bp->current_component to
 always be the short slug. But that move wreaked all sorts of havoc with
 the way that the options_nav is built and displayed. Writing this patch
 has made me realize that those parts of BP sorely need rebuilding, but
 that's out of scope for this dev cycle.

 I'm asking for two kinds of feedback:
 1) Apply the patch to your local installation and let me know whether the
 thing actually works with activity and groups
 2) Have a look at my methods and let me know what you think. As discussed
 above, this patch will break some plugins, but the introduction of a very
 generous bp_core_is_current_component() should make the process of
 updating plugins very easy for plugin authors (I did a grep search and
 replace in just a few minutes). I'm not very happy about the technique I
 use at the beginning of bp_get_options_nav() to decide which nav items to
 load, but again, given the way that BP currently works, this may be the
 best we can do.

 Quick feedback would be much appreciated, as this kind of extensive patch
 will go stale very quickly, and I'll need to extend the technique to the
 remaining components for a full patch (though groups was the hard one).

Ticket URL: <https://trac.buddypress.org/ticket/2600#comment:6>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list