[buddypress-trac] [BuddyPress] #3009: bp-activity-comments Vs. wp-comments

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Mon Jan 17 08:47:25 UTC 2011

#3009: bp-activity-comments Vs. wp-comments
 Reporter:  hnla         |      Owner:  hnla
     Type:  enhancement  |     Status:  new
 Priority:  normal       |  Milestone:  Awaiting Review
Component:  Core         |    Version:  1.3
 Keywords:  has-patch    |
 In reference to this thread:


 I'm proposing a quick fix short term solution for changing activity
 comments to use a OL list in place of the hardcoded UL.

 Comments are correctly described using an OL list  and this is as used by

 bp-activity-templatetags.php ~line 695 has hardcoded markup where it
 doesn't really belong (at least to that degree) as noted by the script
 comment to remove.

 Attached is a quick patch to that file changing UL to OL however I have
 just realised that we have jQuery at work overriding this markup so that
 needs to be found and also changed.

 There is a possible backwards compatibility issue for child themes if they
 have styles on ul.commentlist but that is one example of why best not to
 style in that manner with dynamic  themeable apps. regardless of breaking
 the odd theme I would argue this change still needs to be effected
 otherwise we run in fear of ever making necessary changes, it is not too
 much to ask that child themes update and that authors check the release
 notes before upgrading!

Ticket URL: <https://trac.buddypress.org/ticket/3009>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list