[buddypress-trac] [BuddyPress] #3047: jQuery not properly enqueued in all circumstances
buddypress-trac at lists.automattic.com
buddypress-trac at lists.automattic.com
Fri Feb 4 16:09:16 UTC 2011
#3047: jQuery not properly enqueued in all circumstances
------------------------+-----------------------------
Reporter: johnpbloch | Owner:
Type: defect | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Core | Version: 1.3
Keywords: |
------------------------+-----------------------------
In the function {{{bp_core_confirmation_js()}}}, BuddyPress echoes inline
javascript with jQuery directly to the {{{<head>}}} section without
properly checking to make sure jQuery has been loaded. Since BuddyPress
doesn't normally run without jQuery by default, this isn't generally a
problem. However, if using the BP Template Pack, one has the option of
turning off the default javascript and CSS. If you do that, the core
confirmation script still runs without the jQuery dependency in place.
{{{bp_core_confirmation_js()}}} should be checking if jQuery has been
loaded, and should load it if it hasn't been. I have a working patch which
I'll attach momentarily.
--
Ticket URL: <https://trac.buddypress.org/ticket/3047>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list