[buddypress-trac] [BuddyPress] #3886: Audit class methods and mark appropriately as static (was: Non-static method BP_Core_Notification::get_all_for_user() should not be called statically)

[buddypress-trac at lists.automattic.com]

#3886: Audit class methods and mark appropriately as static
-----------------------------------+-----------------------------
 Reporter:  kayue                  |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  Future Release
Component:  Notifications          |     Version:
 Severity:  minor                  |  Resolution:
 Keywords:  needs-patch 1.7-early  |
-----------------------------------+-----------------------------
Changes (by DJPaul):

 * keywords:  needs-patch => needs-patch 1.7-early
 * milestone:  Awaiting Review => Future Release


Old description:

> Non-static method BP_Core_Notification::get_all_for_user() should not be
> called statically in /buddypress/bp-members/bp-members-notifications.php
> line 51

New description:

 Non-static method BP_Core_Notification::get_all_for_user() should not be
 called statically in /buddypress/bp-members/bp-members-notifications.php
 line 51

 Marking this ticket for 1.7 so we can do all of these at the same time,
 and make sure we have plenty of time to check for any breakages.

--

Comment:

 We need to look at all of BuddyPress, and mark class methods as static
 where appropriate. There was a conversation on IRC
 (https://irclogs.wordpress.org/chanlog.php?channel=buddypress-
 dev&day=2011-12-21#m155663) between Spadeski and boonebgorges recently
 about the same thing.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3886#comment:2>
BuddyPress <http://buddypress.org/>
BuddyPress