[buddypress-trac] [BuddyPress] #3882: Cannot update Setting on the Settings page.

[buddypress-trac at lists.automattic.com]

#3882: Cannot update Setting on the Settings page.
----------------------------+------------------
 Reporter:  fanquake        |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  1.6
Component:  Administration  |     Version:
 Severity:  critical        |  Resolution:
 Keywords:                  |
----------------------------+------------------

Comment (by boonebgorges):

 There were a couple problems:
 - The Settings API save methods do not work with Multisite. That is, you
 can use add_settings_section() etc to display the markup, but there is
 nothing in WP that will automatically catch and save our settings on save
 when using MS (unlike options.php in non-MS). I'm implementing our own
 save routine for the moment. See #3835, #WP15691, #WP18285
 - In r5524, some new settings were registered that may have been intended
 to supplant some of our old settings. For example, I assume that
 _bp_avatar_upload is supposed to replace bp-disable-avatar-uploads.
 However, this was not fully implemented, and no work has been done to
 actually do the replacement throughout BuddyPress. For the moment, I'm
 leaving the code that registers these settings, but we will not be using
 them for BP 1.6.
 - There were a few logic errors related to checked() and the fact that
 some of our BP settings say the opposite of what the UI says (for
 instance, our UI says "Enable profile sync?" but the saved setting is 'bp-
 disable-profile-sync'.

 These changes mean that the settings now work. That's where it should
 stand for BP 1.6. In the future, we will have to make some decisions as a
 team: Are we going to fully migrate to the Settings API (note that we
 cannot until it's fixed for Multisite)? Are we going to migrate to the new
 settings keys (_bp_avatar_upload etc), and if so, how are we going to
 manage backpat? Etc.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3882#comment:3>
BuddyPress <http://buddypress.org/>
BuddyPress