[buddypress-trac] [BuddyPress] #3389: Enqueueing CSS of bp-default breaks child theme layouts

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Wed Aug 31 22:44:34 UTC 2011


#3389: Enqueueing CSS of bp-default breaks child theme layouts
-----------------------+------------------
 Reporter:  mercime    |       Owner:
     Type:  defect     |      Status:  new
 Priority:  normal     |   Milestone:  1.5
Component:  Theme      |     Version:
 Severity:  normal     |  Resolution:
 Keywords:  has-patch  |
-----------------------+------------------

Comment (by r-a-y):

 3384.04.patch implements the ideas in
 [http://buddypress.trac.wordpress.org/ticket/3389#comment:41 my previous
 comment].

 Except for the use of ob_start() in the 'get_header' action, I like this
 approach because:

 * We let child themes continue to @import if they already set it up in
 their stylesheet. (We shouldn't ever be trying to change how child themes
 markup their styles.)
 * We properly enqueue a child theme's stylesheet, while stopping bp-
 default from being greedy by enqueueing default.css

 I hate the fact that I'm using ob_start() though.  Need some feedback for
 how to combat this when newer child themes decide to plug
 bp_dtheme_enqueue_styles().

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3389#comment:42>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list