[buddypress-trac] [BuddyPress] #3481: Group extension PHP warning when visibility != 'public'

[buddypress-trac at lists.automattic.com]

#3481: Group extension PHP warning when visibility != 'public'
--------------------------+-----------------
 Reporter:  boonebgorges  |      Owner:
     Type:  defect        |     Status:  new
 Priority:  minor         |  Milestone:  1.5
Component:  Groups        |    Version:
 Severity:  minor         |   Keywords:
--------------------------+-----------------
 In BP_Group_Extension::__register(), you get a PHP warning if the tab
 visibility is not set to public and you look at a non-group page. That's
 because we check $bp->groups>current_group->user_has_access, which will
 not be populated when you're not looking at a specific group.

 More generally, we don't need to be adding nav items to the group nav if
 we're not looking at a single group (and in fact, we are not doing so -
 currently there are a bunch of is_single_item checks). I'm going to move
 them all into a single bp_is_group() wrapper that will be more efficient
 and also solve the PHP warning.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3481>
BuddyPress <http://buddypress.org/>
BuddyPress