[buddypress-trac] [BuddyPress] #3445: Blog posts not showing in activity stream

[buddypress-trac at lists.automattic.com]

#3445: Blog posts not showing in activity stream
--------------------------------------------------+------------------
 Reporter:  modemlooper                           |       Owner:
     Type:  defect                                |      Status:  new
 Priority:  critical                              |   Milestone:  1.5
Component:  Activity                              |     Version:  1.5
 Severity:  critical                              |  Resolution:
 Keywords:  dev-feedback has-patch needs-testing  |
--------------------------------------------------+------------------

Comment (by boonebgorges):

 Thanks for the patch, DJPaul. Looks mostly good. I have made a few tweaks:

 1) Changed some wording, especially to account for the fact that non-MS
 installations will not have a Sites directory.
 2) Set $bp->blogs->has_directory to is_multisite()
 3) Fixed the places where the original patch wouldn't apply cleanly
 because of recent whitespace cleanup :)

 step_ms_update(): I think we need to keep step_ms_update(). Someone who
 has disabled the Blogs component on non-MS may very well want it enabled
 on MS. Moreover, even if we assume that activation status will remain, we
 need to prompt to create a Sites directory page (since one does not exist
 on non-MS).

 ->has_directory during update: It's not possible to check this
 consistently, because during initial installation of BP, the rest of the
 BP files have not been loaded, with the result that the components have
 not registered themselves, and ->has_directory is not populated one way or
 the other. As an alternative, I have simply opted not to show the Sites
 option during step_pages() when !is_multisite(), with the result that no
 page is created. I think this is the best we can do at the moment.

 See 3445-2.patch

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3445#comment:6>
BuddyPress <http://buddypress.org/>
BuddyPress